Speed up worker metric handler test#804
Open
timmartin-stripe wants to merge 1 commit intoNetflix:masterfrom
Open
Speed up worker metric handler test#804timmartin-stripe wants to merge 1 commit intoNetflix:masterfrom
timmartin-stripe wants to merge 1 commit intoNetflix:masterfrom
Conversation
This test was very slow and irritating me when running tests. Made the metrics collection interval configurable so that we could turn it down.
timmartin-stripe
requested review from
Andyz26,
calvin681,
dtrager02,
fdc-ntflx,
hellolittlej and
james-lubin
as code owners
Andyz26
approved these changes
Oct 27, 2025
timmartin-stripe
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
| final MantisMasterGateway masterClientApi, | ||
| final AutoScaleMetricsConfig autoScaleMetricsConfig, | ||
| final JobAutoscalerManager jobAutoscalerManager, | ||
| final int metricsIntervalSeconds) { |
Collaborator
There was a problem hiding this comment.
why does this need to be on WorkerMetricHandler? looks it only used in stageMetricDataOperator?
Contributor
Author
There was a problem hiding this comment.
My thought process was that WorkerMetricHandler is responsible for instantiating the StageMetricDataOperator. The alternative would be to pass it in directly via the initAndGetMetricDataObserver method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This test was very slow and irritating me when running tests. Made the metrics collection interval configurable so that we could turn it down.
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests